Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document service options in default.spec #1653

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Aug 3, 2023

Also trivial copy-edits to other comments.

@Julian-O
Copy link
Contributor Author

Julian-O commented Aug 4, 2023

Slipped in another comment to explain how to find what bootstrap options were valid.

Comment on lines 61 to 66
# (list) List of services to declare
# Each service consists of a name (a valid Java class name, with the first letter capitalized)
# followed by a colon, followed by the name of the Python script (.py file) that should be
# launched. This is optionally followed by ":foreground" for foreground services or
# ":foreground:sticky" for sticky foreground services. The default is a background service.
# Bound services are not supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to say that (at least ATM) this is an android-specific feature, even if does not have the android.* prefix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I hadn't even noticed it didn't have an android prefix. I am on it.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit 2e547c9 into kivy:master Aug 6, 2023
14 checks passed
@Julian-O Julian-O deleted the commentsdefault.spec branch August 27, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants